search

RobotLocomotion / drake-external-examples

Examples of how to use Drake in your own project.
https://drake.mit.edu/
MIT No Attribution
105 stars 50 forks source link

Need to fail-fast on deprecations #159

Open EricCousineau-TRI opened 4 years ago

EricCousineau-TRI commented 4 years ago

Deprecations generally slip through, and cause breakage when their removed.

jwnimmer-tri commented 4 years ago

I broke drake-external-examples master again because of this via https://reviewable.io/reviews/RobotLocomotion/drake/12680. Drake removed a deprecated text_logging_gflags header, but it remained used by drake-external-examples until it was fully removed and thus broke the build.

EricCousineau-TRI commented 4 years ago

Per f2f: C++ should be easy (-Wdeprecations or what not), if we're not already doing that.

For Python, will be annoying (env vars with test runners, updating each testing mode, or parsing stdout), but doable.

jwnimmer-tri commented 2 years ago

Note that we can't just turn on -Werror -- these repositories are intended for users to copy into their own project, and we don't want them using -Werror. So the trick is to find a way for us to get CI reports about these, but for that not to propagate that into users' replicas of this.

jwnimmer-tri commented 3 months ago

I think when I work on https://github.com/RobotLocomotion/drake/issues/19167 soon, I should circle back and toggle it here as well.