search

RobotLocomotion / drake-external-examples

Examples of how to use Drake in your own project.
https://drake.mit.edu/
MIT No Attribution
106 stars 50 forks source link

Fix ament cmake transitive dependency issue #293

Closed weithegreat closed 1 month ago

weithegreat commented 5 months ago

The current amend cmake example build without problem, however there will be issue finding drake dependency for libraries depends on such a library

Closes #292.

This change is Reviewable

weithegreat commented 5 months ago

@jwnimmer-tri Hey Jeremy would you mind taking a look at this PR?

jwnimmer-tri commented 5 months ago

+@IanTheEngineer do you know any https://github.com/RobotLocomotion/drake-ros member who would like to review this?

To me, the ament part looks okay, but manually setting LD_LIBRARY_PATH is usually an obscenity and should be avoided with prejudice. Hopefully there is another way to get it working. I imagine the ament ecosystem already has some better way to deal with library paths?

jwnimmer-tri commented 2 months ago

@IanTheEngineer last call to find someone to support this ament example.

If we can't find anyone to support it, then I will merge this PR as-is and follow up by documenting the ament example as outside of our support footprint, i.e., "community maintained - PRs welcome" and remove it from CI.

jwnimmer-tri commented 2 months ago

I should probably ping @EricCousineau-TRI also.