Hoist subdir chdir from setup scripts into GHA yaml

RobotLocomotion / drake-external-examples

Examples of how to use Drake in your own project.

https://drake.mit.edu/

MIT No Attribution

106 stars 50 forks source link

Hoist subdir chdir from setup scripts into GHA yaml #342

Closed jwnimmer-tri closed 5 days ago

jwnimmer-tri commented 5 days ago

The scripts shouldn't be copy-pasting their own project name.

This commit was carved out of #333, authored by @nicolecheetham. We should land the straightforward and uncontroversial boilerplate refactoring separately from the new-feature pieces, not only as a general best practice but more acutely because the refactoring is holding up related pull requests like #341.

This change is

jwnimmer-tri commented 5 days ago

both reviews.

It looks like macOS CI has been broken for a couple days. I don't plan to block on it here.