RobotLocomotion / drake-iiwa-driver

BSD 3-Clause "New" or "Revised" License
24 stars 30 forks source link

Build the driver with bazel #10

Closed sammy-tri closed 6 years ago

sammy-tri commented 6 years ago

This is "my first bazel" type of work here. There was a lot of cargo culting and trial and error. Apologies for the parts I got wrong.


This change is Reviewable

sammy-tri commented 6 years ago

BTW most of the contents of tools was copied from drake directly, with the exception of kuka-fri.BUILD

+@siyuanfeng-tri for review/testing.


Review status: 0 of 22 files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

siyuanfeng-tri commented 6 years ago
:lgtm:

Reviewed 22 of 22 files at r1, 1 of 2 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.


tools/kuka-fri.BUILD, line 29 at r1 (raw file):

        ],
    #cmd = "echo $(location include/friClientApplication.h) $(location friClientApplication.h) $(location libFRIClient.a) $(location build/GNUMake/Makefile)",
    cmd = "make -C external/kuka_fri/build/GNUMake &&" +

BTW this is basically calling make, and copy the stuff to somewhere else?


tools/kuka-fri.BUILD, line 28 at r2 (raw file):

        "friConnectionIf.h",
        ],
    #cmd = "echo $(location include/friClientApplication.h) $(location friClientApplication.h) $(location libFRIClient.a) $(location build/GNUMake/Makefile)",

BTW do you want to rm this line?


Comments from Reviewable

sammy-tri commented 6 years ago

Review status: 20 of 22 files reviewed at latest revision, 1 unresolved discussion.


tools/kuka-fri.BUILD, line 29 at r1 (raw file):

Previously, siyuanfeng-tri wrote…
BTW this is basically calling make, and copy the stuff to somewhere else?

(resolved f2f)


tools/kuka-fri.BUILD, line 28 at r2 (raw file):

Previously, siyuanfeng-tri wrote…
BTW do you want to rm this line?

Done.


Comments from Reviewable

siyuanfeng-tri commented 6 years ago

Reviewed 2 of 2 files at r3. Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable