search

RobotLocomotion / drake-iiwa-driver

BSD 3-Clause "New" or "Revised" License
24 stars 30 forks source link

find gflags for CMake build #19

Closed peteflorence closed 6 years ago

peteflorence commented 6 years ago

Based on @jwnimmer-tri pointing me to shambhala's fix, this now works for drake-iiwa-driver cmake build

Only PRing into master-rlg, but if master wants to support the CMake build, would need something like this.

This change is Reviewable

manuelli commented 6 years ago
:lgtm:

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

sammy-tri commented 6 years ago

I dream of a day/world where we don't copy elaborate configuration files around to make our build systems work (I'm looking at you too, bazel). Unfortunately this is not that day.

:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

peteflorence commented 6 years ago

:) yes well said @sammy-tri