search

RobotLocomotion / drake-iiwa-driver

BSD 3-Clause "New" or "Revised" License
24 stars 30 forks source link

Find drake lcmtypes interface library #4

Closed fbudin69500 closed 7 years ago

fbudin69500 commented 7 years ago

This project requires some lcm types from drake but that dependency was not explicit.

This change is Reviewable

fbudin69500 commented 7 years ago

@sammy-tri : This is the follow-up of this previous PR

sammy-tri commented 7 years ago

Works for me with the current drake CMake build. It looks like it should with with the installed bazel-build drake artifacts too from my first glance, but I haven't tested it (since I'm still not sure how to build the intended results). Is it believed to work in that scenario too?

Reviewed 2 of 2 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

fbudin69500 commented 7 years ago

Indeed, the scenario which lead me to update these files is when bazel-build drake, which is what I have tested it with on my computer.

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable

sammy-tri commented 7 years ago
:lgtm:

Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable