autopybind: Should test current workflows for automated bindings

RobotLocomotion / drake

Model-based design and verification for robotics.

https://drake.mit.edu

Other

3.27k stars 1.26k forks source link

autopybind: Should test current workflows for automated bindings #14827

Closed EricCousineau-TRI closed 2 years ago

EricCousineau-TRI commented 3 years ago

As part of #7889, using #14265 (now #15205)

I've chosen the following symbols to genuinely try this workflow out on:

New bindings:
- Non-templated:
- [ ] #14828 drake::geometry::render::RenderEngineGlParams
- [ ] ~drake::multibody::StaticEquilibriumConstraint~ This has weird API (returns type from internal:: namespace)
- Templated:
- [ ] drake::systems::sensors::Accelerometer
- [ ] drake::systems::PortSwitch
Update bindings
- Non-templated:
- [ ] drake::solvers::MixedIntegerBranchAndBound
- Templated:
- [ ] drake::systems::SurfaceMesh
- [ ] drake::multibody::MultibodyPlant

EricCousineau-TRI commented 3 years ago

FYI @josephsnyder

EricCousineau-TRI commented 3 years ago

My plan is to make the PR, but will strive to record what was necessary to go from generated bindings to my own liking as well as reviewer acceptance.

EricCousineau-TRI commented 3 years ago

For RenderEngineGlParams, see commits 56700ca7a4 and bde2a425f1 for final products. Branch: https://github.com/EricCousineau-TRI/drake/tree/issue-14827-wip

@jamiesnape and @josephsnyder I've added opinionated steps that I took here to make initial state of #14828: https://github.com/RobotLocomotion/drake/blob/56700ca7a4/tools/autopybind/README.md#steps-taken

Can both of you please review my steps here and let me know if there is anything better that I could have done? I will file an issue about adding an option to suppress warnings (done), and ~possibly provide more user-friendly errors if a symbol isn't found in a file~ (I don't know how to request this).

Given current workflow for a simple case, I would still like to wait until certain parts of the denoising happen before asking anyone else to run this.

EricCousineau-TRI commented 3 years ago

Tried drake::multibody::StaticEquilibriumConstraint. Punted because of weird API (our fault), but there were still pain points w.r.t. autopybind11: https://github.com/EricCousineau-TRI/drake/blob/f25751c7ca64755e55ade1ae10073937b25aeb5b/tools/autopybind/README.md#for-staticequilibriumconstraint

EricCousineau-TRI commented 3 years ago

I'm pausing any more of my effort on this until denoising lands.

jwnimmer-tri commented 2 years ago

Closing out as "unlikely to reach an actionable state within a reasonable timeframe".