Don't use lsb_release in repack_deb

RobotLocomotion / drake

Model-based design and verification for robotics.

https://drake.mit.edu

Other

3.18k stars 1.24k forks source link

Don't use lsb_release in repack_deb #21489

Closed mwoehlke-kitware closed 1 month ago

mwoehlke-kitware commented 1 month ago

Refactor repack_deb to directly read os-release, as Python bindings for lsb_release are no longer included on Noble. (Anyway, LSB is essentially abandoned since 2015, and the Python bindings were already just reading /etc/os-release.)

Fixes #21488.

This change is

mwoehlke-kitware commented 1 month ago

+@jwnimmer-tri for review (both?), please.

jwnimmer-tri commented 1 month ago

@drake-jenkins-bot linux-jammy-unprovisioned-gcc-cmake-experimental-packaging please @drake-jenkins-bot linux-noble-unprovisioned-gcc-cmake-experimental-packaging please

mwoehlke-kitware commented 1 month ago

I'm... not sure what went wrong on Noble? It looks like it got past repack_deb anyway, so maybe an improvement?

jwnimmer-tri commented 1 month ago

Yup. This problem is fixed. That error (Dockerfile setup) is another new problem.