search

RobotLocomotion / drake

Model-based design and verification for robotics.
https://drake.mit.edu
Other
3.27k stars 1.26k forks source link

[solvers] Add SemidefiniteRelaxationOptions #21500

Closed AlexandreAmice closed 3 months ago

AlexandreAmice commented 4 months ago

This change is Reviewable

jwnimmer-tri commented 3 months ago

Sure. Certainly by Monday EOD.

jwnimmer-tri commented 3 months ago

When a pull request only moves a little code, then adding novel code in the same PR is OK. This pull request moves a ginormous amount of code, but still adds new novelty, so is impossible to review as a monolith -- the review tips in the code don't really help, since there is no reasonable way to obtain a diff of just the novelty. We need two separate PRs for review: one that moves code, and the second one that adds novelty. To help move this along, I'll prepare the move-only PR and submit it for solo platform review with tomorrow's reviewer. After that, you can merge up this PR to just contain the novelty.