search

RobotLocomotion / drake

Model-based design and verification for robotics.
https://drake.mit.edu
Other
3.17k stars 1.24k forks source link

[parsing] Fix name clash of collision filter groups #21529

Closed rpoyner-tri closed 1 week ago

rpoyner-tri commented 4 weeks ago

This patch fixes a name clash of collision filter groups when loading the same model multiple times using auto-renaming and plant.RenameModel().

This change is Reviewable

jwnimmer-tri commented 3 weeks ago
Previously, rpoyner-tri (Rick Poyner (rico)) wrote…
Holding on this until the c++ spellings get stabilized.

I'm happy with the public API signatures now. Feel free to bind anytime.

jwnimmer-tri commented 3 weeks ago

The lack of useful spaceship support is a valid reason to bump up our minimum supported XCode. I filed https://github.com/RobotLocomotion/drake/issues/21557 to upgrade CI from 14 to 15. (This assumes that XCode 15 can be installed on Ventura, but per Apple docs it seems like it will work OK.)

... says we don't support Xcode 13. Can we get mac CI fixed?

I'm not where you were seeing CI using 13? In the log I only see macOS 13, not XCode 13?

rpoyner-tri commented 2 weeks ago

One alternative is to just make filter introspection mbp and scenegraph's problem in the first place. If they are going to arbitrarily mutate the data, the parser is just the wrong place to track it.

Another alternative is to abandon accumulation; you only ever get the filters found in the last parse call.

jwnimmer-tri commented 1 week ago

Oops. :lgtm:

jwnimmer-tri commented 1 week ago

The macOS CI is back online, and has passed.