search

RobotLocomotion / drake

Model-based design and verification for robotics.
https://drake.mit.edu
Other
3.17k stars 1.24k forks source link

The `new_release` script reports the incorrect version for ros_xacro_internal #21535

Closed BetsyMcPhail closed 6 days ago

BetsyMcPhail commented 3 weeks ago

What happened?

While doing the monthly external upgrades as part of #21507, bazel-bin/tools/workspace/new_release reported that: ros_xacro_internal needs upgrade from 2.0.10 to xacro-1.7.5 The version to upgrade to should be 2.0.11.

Version

No response

What operating system are you using?

No response

What installation option are you using?

No response

Relevant log output

No response

jwnimmer-tri commented 3 weeks ago

Best guess, we need to update this pattern to ignore those really old tags that start with xacro-...: https://github.com/RobotLocomotion/drake/blob/7228fd95e301bf0bea212bca23c60b42a6989b63/tools/workspace/new_release.py#L78

BetsyMcPhail commented 3 weeks ago

Related to this, I've been caught twice by the Gymnasium update to v1.0.0a1. The new_release script should ignore alpha/beta/pre-releases.

mwoehlke-kitware commented 3 weeks ago

The new_release script should ignore alpha/beta/pre-releases.

We do that for ["alpha", "beta", "rc", "pre"] in _is_ignored_tag. The parsing is fairly dumb (it just checks if those strings are anywhere in the commit), so I don't think you'd want to add a to the global ignore list, but this looks like a good case for adding a rule to _IGNORED_TAGS.