Add mujoco_menagerie as a test-only dependency

RobotLocomotion / drake

Model-based design and verification for robotics.

https://drake.mit.edu

Other

3.17k stars 1.24k forks source link

Add mujoco_menagerie as a test-only dependency #21649

Closed RussTedrake closed 2 days ago

RussTedrake commented 3 days ago

And use it for testing the mujoco parser. Towards #20444 and #21648.

This change is

RussTedrake commented 3 days ago

+@jwnimmer-tri for feature review of build-system, please.

jwnimmer-tri commented 3 days ago

See https://github.com/RussTedrake/drake/pull/56 for changes.

jwnimmer-tri commented 3 days ago

(I also changed the release notes tag -- adding new dependencies to the workspace is notable.)

RussTedrake commented 3 days ago

thanks @jwnimmer-tri -- are you satisfied enough to give one or both LGTMs?

jwnimmer-tri commented 3 days ago

Build system stuff looks good now.

Both for reasons of time, and somewhat because I co-authored, we should probably find someone else to review -@jwnimmer-tri.

Probably @joemasterjohn or @rpoyner-tri would be good for feature review, or maybe @sherm1 feels confident enough to do both reviews.

RussTedrake commented 3 days ago

+@rpoyner-tri for feature review, please (unless @sherm1 feels good to take both) +@sherm1 for platform review, please.

jwnimmer-tri commented 2 days ago

~If your only doubt is about the build system (rather than parser semantics), then I've already LGTMd the build system, in a sense. I mean, I wrote the code for it, so I believe it's using the correct habits. The only question is if it makes sense to you with fresh eyes.~

Update: If Russ fixes my BTW below, then this PR becomes boring and we can do the following:

Count me as author for the build system, and Russ as feature reviewer.
Count Russ as author for the new test cases, and me as feature reviewer.
Sherm as platform for everything.

The only thing we lack feature review on is the weird docs change.