RenderEngineVtk can be forced into PBR mode

RobotLocomotion / drake

Model-based design and verification for robotics.

https://drake.mit.edu

Other

3.35k stars 1.27k forks source link

RenderEngineVtk can be forced into PBR mode #22170

Open SeanCurtis-TRI opened 1 week ago

SeanCurtis-TRI commented 1 week ago

Adds a new parameter to RenderEngineVtkParams. Rather than waiting for the engine's lighting model to get promoted based on its content, it can be pushed into that mode upon construction.

This also fixes a bug in which cloned instances forgot whether or not phong materials should be automatically promoted to PBR.

This change is

jwnimmer-tri commented 1 week ago

FYI The change-detector test render_engine_vtk_params_test needs a small fix now for CI.

SeanCurtis-TRI commented 1 week ago

-- commits line 15 at r2: This introduces some cruft so I could better assess the nature of the CI test failure.

SeanCurtis-TRI commented 5 days ago

-(status: do not review)

sherm1 commented 4 days ago

Is this ready for feature review now, Sean?