[multibody] Remove dynamic_cast from inline get-downcast functions

RobotLocomotion / drake

Model-based design and verification for robotics.

https://drake.mit.edu

Other

3.35k stars 1.27k forks source link

[multibody] Remove dynamic_cast from inline get-downcast functions #22209

Open jwnimmer-tri opened 4 days ago

jwnimmer-tri commented 4 days ago

The dynamic_cast operation does not meet our styleguide requirements for being inline. We need to move the definitions to the cc files.

This change is tangentially inspired by https://github.com/RobotLocomotion/drake/issues/22204.

This change is

jwnimmer-tri commented 3 days ago

FYI @rpoyner-tri I am not going to try to get this reviewed and merged until next week, but in case it helps your testing feel free to cherry-pick it for now.