search

RobotLocomotion / drake

Model-based design and verification for robotics.
https://drake.mit.edu
Other
3.34k stars 1.27k forks source link

Bad attributes in mexfiles break mac matlab builds #3223

Closed ggould-tri closed 8 years ago

ggould-tri commented 8 years ago

3065 appears to have caused a nightly CI failure at https://drake-cdash.csail.mit.edu/viewBuildError.php?buildid=88374 . This is acknowledged at #3206 in the comment at https://github.com/RobotLocomotion/drake/pull/3206#issuecomment-241474837 .

The failure text is a number of instances of:

/Users/elcapitan/workspace/mac-clang-nightly-matlab-debug/drake/util/drakeMexUtil.cpp:457:10: error: an attribute list cannot appear here
template DLLEXPORT mxArray* eigenToMatlabSparse(MatrixBase<MatrixXd> const&,
         ^~~~~~~~~
/Users/elcapitan/workspace/mac-clang-nightly-matlab-debug/drake/../drake/util/drakeMexUtil.h:38:19: note: expanded from macro 'DLLEXPORT'
#define DLLEXPORT [[gnu::visibility("default")]]

Assigning to @mwoehlke-kitware as he is responsible for #3065 and #3206.

Because #3206 indicates that this is a known issue being actively worked, I am not dropping the revert hammer on it just yet.

jwnimmer-tri commented 8 years ago

Was #3210 the fix for these, perhaps?

mwoehlke-kitware commented 8 years ago

Was #3210 the fix for these, perhaps?

Yes. (Supposed to be at least... is it still failing? That just got merged, so the failures may predate it...)

mwoehlke-kitware commented 8 years ago

(Oh, I see... yes, #3210 didn't land in time to fix last night's nightlies, and there are no corresponding continuous builds that show this error.)

ggould-tri commented 8 years ago

I confirm that the build failure is no longer present in nightly (that nightly is yellow, but for other reasons) and so am closing this issue.

Thank you.