RobotLocomotion / drake

Model-based design and verification for robotics.
https://drake.mit.edu
Other
3.33k stars 1.26k forks source link

Clean up event system API documentation #6456

Closed SeanCurtis-TRI closed 4 years ago

SeanCurtis-TRI commented 7 years ago

The new API for the event system is far-reaching and complex. The decision was made to allow it through without having wholly satisfying documentation because of its complexity. Accordingly, this issue is intended to track the known documentation issues (which may or may not be specifically called out in todos in the code):

Doxygen needs:

Implementation details for developers:

edrumwri commented 4 years ago

Just a couple of comments on the issue since it's finally receiving attention. One note is that Reviewable is failing to preserve context with the review comments (the comments are intact but the places pointed to in the code are not.)

Doxygen needs:

  * Guide to authors of a new `LeafSystem`s, what type of events they would register,

I agree completely and started to add this to LeafSystem. Unfortunately, there is now zero information for LeafSystem authors so adding info about events there would now be incongruous. Issue #8616 already covers that issue (I've updated it to point this out). I also put a little info into my upcoming PR (#12501) for addressing this present issue.

  * [ ]  `GetSubSystemStuff()`. Probably need to revisit the _name_ of this method.

It's used for lots of, ahem, stuff, so I think this uninformative name is actually appropriate.