RobotLocomotion / models

Shareable model files (urdf/sdf + meshes, etc) for our robotics projects
27 stars 23 forks source link

wsg_50 mesh files added #13

Closed hjsuh94 closed 4 years ago

hjsuh94 commented 4 years ago

From Drake PR: https://github.com/RobotLocomotion/drake/pull/13922

This PR submits the mesh portion of the new WSG-50 visualization.


This change is Reviewable

hjsuh94 commented 4 years ago

@RussTedrake for review please!

jwnimmer-tri commented 4 years ago

... converted from the original CAD files downloaded from the Schunk's website on WSG 050-110-P mode ...

Could you please post here under what license (that permits redistribution) those CAD files were offered under at the website? I pulled up the URL from this README but wasn't able to see it in the first click or two. All I found was a form where it would email me the CAD files -- if that's how you got them, maybe the email contained redistribution info?

hjsuh94 commented 4 years ago

Thank you @sammy-tri and @jwnimmer-tri !

I'm still trying to look for what the exact license files are - so far I'm kind of lost, but I think you are right this file is from PARTcommunity, and their terms of use file did refer to the Cadenas terms of use.

One workaround is we just CAD our own files from the drawings on Schunk's website, such as their product catalog posted here: https://schunk.com/fileadmin/pim/docs/IM0026091.PDF

that way we have nothing to do with Cadenas. But what are the licenses on Schunk's drawings??

hjsuh94 commented 4 years ago

@sammy-tri @jwnimmer-tri I created a CAD myself from Schunk's drawing file as opposed to downloading them from CADENAS, and the corresponding LICENSE file has been included in the directory.

Let me know if it looks good to merge!

jwnimmer-tri commented 4 years ago

Either the dimensioned drawings came with a license file that we reproduce here and credit to Schunk GmbH, or they did not and the LICENSE file in this PR must not give Schunk GmbH as a copyright owner -- only your employer is the owner, since you created the files here. If Schunk GmbH is a copyright owner, we must copy only under their terms; your claim is that they are not an owner, and so you don't have to follow any particular license of theirs.

As for whether creating a mesh file from a dimensioned drawing is copyright infringement, I'd be curious to hear your take on whether any of this advice applies: http://patentonomy.blogspot.com/2012/06/copyright-protection-for-mechanical.html.

Of course, I am not a lawyer and neither is "googling it". I really have no idea how to try to legally create a mesh of a robot where the vendor does not provide for redistributable meshes in the first place. We should ask a real lawyer, and/or ask Schunk to release the data under a FOSS license.

hjsuh94 commented 4 years ago

@jwnimmer-tri Thank you for the feedback!

This is getting confusing - the drawings definitely have Schunk's copyright on it (but no clear license), so it somehow seems like while I made this file, it is still their copyright?

I agree it is useless to guess - the fastest way must be to contact a lawyer, or Schunk directly so we have a clean solution to this.

@RussTedrake it looks like this PR might take a while due to strange legal issues!

jwnimmer-tri commented 4 years ago

... it somehow seems like while I made this file, it is still their copyright?

If you transcribed the dimensioned drawing into another dimensioned drawing with the original drawing "by your left elbow", I believe that would be infringement. As to whether a mesh transcription is also infringing, I cannot be sure. It might be sufficient to move forward. Notably a third option beyond "ask a lawyer" and "ask Shunk for permission" would be "Russ blesses it as sufficient". It's above my pay grade, though.

hjsuh94 commented 4 years ago

DONE. Schunk's copyright line has been removed!

hjsuh94 commented 4 years ago

Per conversation with @jwnimmer-tri , all aesthetic components have been deleted and the meshes have been reduced down to necessary functional components.

Screenshot from 2020-08-27 15-15-54 Screenshot from 2020-08-27 15-16-31

Let me know if the aesthetics needs to be decreased further!

jwnimmer-tri commented 4 years ago

This all looks good to me, including the README and LICENSE. I'll let @sammy-tri double check.