search

RobotLocomotion / models

Shareable model files (urdf/sdf + meshes, etc) for our robotics projects
25 stars 23 forks source link

[dishes,veggies] Tidy up hydro tutorial #60

Closed jwnimmer-tri closed 3 months ago

jwnimmer-tri commented 3 months ago

Move tutorial notebook literal strings to here. Add missing xmlns stuff. Don't use CamelNames for models; always match the filename. Remove useless pose offsets. Standardize visual vs collision geometry naming.

Twin PR: https://github.com/RobotLocomotion/drake/pull/21258

This change is Reviewable

jwnimmer-tri commented 3 months ago

+@DamrongGuoy for feature review, please.

We had two copies of the bowl sdf file (one here, which was used by the drake example) and another copy inline in the tutorial. The two were somewhat the same but had a bunch of unexplained differences and various bugs / typos / inconsistencies.

I split the difference between the two as best I could, but possibly some proximity properties need a little more fine-tuning. If you think so, you could either push more commits onto this branch with the fixes, or let these twin PRs merge and then open fresh PRs next week with the tweaks.