RobotLocomotion / pytorch-dense-correspondence

Code for "Dense Object Nets: Learning Dense Visual Object Descriptors By and For Robotic Manipulation"
https://arxiv.org/pdf/1806.08756.pdf
Other
559 stars 133 forks source link

Outdated PyTorch in Docker build #194

Closed kingsman142 closed 5 years ago

kingsman142 commented 5 years ago

I'm currently using an RTX 2080 GPU with CUDA 10.0. I kept on having issues where training the network wouldn't work since nothing would be loaded onto the GPU. Installing PyTorch locally for CUDA 10.0 did not work. So, I discovered I had to modify this script and change the pytorch installations for CUDA 10.0:

pytorch-dense-correspondence/docker/install_pytorch.sh

sudo pip install https://download.pytorch.org/whl/cu100/torch-1.1.0-cp27-cp27mu-linux_x86_64.whl
sudo pip install https://download.pytorch.org/whl/cu100/torchvision-0.3.0-cp27-cp27mu-linux_x86_64.whl

sudo pip3 install https://download.pytorch.org/whl/cu100/torch-1.1.0-cp35-cp35m-linux_x86_64.whl
sudo pip3 install https://download.pytorch.org/whl/cu100/torchvision-0.3.0-cp35-cp35m-linux_x86_64.whl

I think it would be best if there was a disclaimer to change these installation URLs in the URL to stay up-to-date with both PyTorch (currently listed as 0.3.0 in the install script) as well as CUDA. I can create a pull request if you want.

manuelli commented 5 years ago

Hi @kingsman142. Yes the pytorch version was pinned to 0.3.0 since that was what was originally used when computing the results for the paper. Updating to pytorch 1.0 is fairly easy (we have done it on a private branch) but we just haven't ported it over to the public repo yet. Hopefully I will open a PR in the next few days with the update.

In the meantime feel free to make a PR with your updates. Good suggestion to add a disclaimer, probably the README is the best place for that.

manuelli commented 5 years ago

There is now an open PR #196 that updates the repo to pytorch 1.1

manuelli commented 5 years ago

199 updates the repo to work with pytorch 1.1