Fix double-free when using typed array

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client

https://docs.ros.org/en/jazzy/Concepts/Basic/About-Client-Libraries.html#community-maintained

Apache License 2.0

325 stars 71 forks source link

Fix double-free when using typed array #679

Closed minggangw closed 4 years ago

minggangw commented 4 years ago

This patch enables to transfer the ownership of ArrayBuffer to v8 when deserializing the messages, which has type of TypedArray. This will avoid double-free when the v8 executes gc.

Fix #673

coveralls commented 4 years ago

Coverage remained the same at 84.399% when pulling 93d9fc8ac6c40116bd86719fd722df71a5fa98ed on minggangw:fix-issue-673 into 9dd9b8b029d46cd2e149ce4a685ecd03e2a11326 on RobotWebTools:develop.