search

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
319 stars 70 forks source link

Add missing type declarations for action server/client destroy methods #690

Closed mattrichard closed 4 years ago

mattrichard commented 4 years ago

Action servers and clients are not created through a node and therefore don't have corresponding destroy methods on the Node class. Instead, to destroy an action server/client outside of destroying the Node itself it is expected to call destroy on the server/client directly. This adds the type declarations for the destroy function which were missing.

Fix #687

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 84.464% when pulling ed369cc1aab267f002bcdead305dcfc12a2f283a on mattrichard:destroytypings into db7721ec3042b355d45089cb77aec9c34c6577b8 on RobotWebTools:develop.