Closed felixdivo closed 3 years ago
Hm, strange. I think this is done, but there's this error: FATAL ERROR: v8::ToLocalChecked Empty MaybeLocal.
on CircleCI and AppVeyor. Has it appeared before? And Travis is failing too, but seemingly unrelated.
@felixdivo I took a quick look and think the problem might be at line 55 in test-logging.js.
My reasoning is that the code where the exception is occurs is:
// preprocess Context
RclHandle* context_handle = RclHandle::Unwrap<RclHandle>(
Nan::To<v8::Object>(info[0]).ToLocalChecked());
Hi @felixdivo would you please create the corresponding issues for this PR and #726, so we could track through issue<->pull request, thanks!
My reasoning is that the code where the exception is occurs is:
// preprocess Context RclHandle* context_handle = RclHandle::Unwrap<RclHandle>( Nan::To<v8::Object>(info[0]).ToLocalChecked());
That's right, we have to pass an instance of Context as the 1st parameter.
Thanks @wayneparrott! It was exactly there. I was fooled by the default value for the context
parameter, which (somewhat obviously) isn't used when passing an argument. It's now fixed. I'll check if the rest now works.
would you please create the corresponding issues for this PR and #726
Done.
And this PR is ready for a review.
This:
async
code,Closes #731