Cleanup Message Generation

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client

https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained

Apache License 2.0

316 stars 70 forks source link

Cleanup Message Generation #726

Closed felixdivo closed 3 years ago

felixdivo commented 3 years ago

This PR closes #732 improves upon #712 by handling other whitespace besides normal spaces in a more robust way. Also cleans up parts of the message/etc. generation process (using async functions).

coveralls commented 3 years ago

Coverage remained the same at 91.207% when pulling 235c65462d1216591c65310ed6b05e35f0d6ddcc on felixdivo:clanup-generation into 09766e34ff2e54e846eec284204fbe120b46d998 on RobotWebTools:develop.

felixdivo commented 3 years ago

Don't really know if the Travis/AppVeyor failures have anything to do this this PR but it not I'm done with this set of changes and ready for a review.

felixdivo commented 3 years ago

I hope it's okay that I've added my name to the list of contributors.

minggangw commented 3 years ago

Hi @felixdivo I noticed that the appveyor always has an error with this PR when generating JavaScript message, please check https://ci.appveyor.com/project/minggangw/rclnodejs/builds/36416972#L438

> rclnodejs@0.16.0 postinstall C:\proj\rclnodejs
> node scripts/generate_messages.js
Start JavaScript message generation...
Caught error: Error

Would you please take a look?

felixdivo commented 3 years ago

This is now fixed.