search

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
316 stars 70 forks source link

Simplify rclnodejs/index.js #737

Closed felixdivo closed 3 years ago

felixdivo commented 3 years ago

Fixes #736.

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 91.515% when pulling 7b1a62e8a3eaaa8d598cb1c3c9e43b41307be95a on felixdivo:simplify-index-js into b09a171b9a97756a79ea93bcc383dfcf2fbe3c5c on RobotWebTools:develop.

felixdivo commented 3 years ago

I don't get why AppVeyor is failing though. But maybe it will go away now. Let's see.

felixdivo commented 3 years ago

I don't get why AppVeyor is failing though. But maybe it will go away now. Let's see.

It didn't. This war the failing test I meant (@minggangw ;)). Seems like node ./scripts/compile_tests.js fails. I can't see why this would be cause by my changes. It appears that a few lines above, this shows up:

> node scripts/generate_messages.js
Start JavaScript message generation...
Incomplete service: test_interface_files.srv.Arrays.
Incomplete service: test_interface_files.srv.BasicTypes.
Incomplete service: test_interface_files.srv.Empty.
Generation complete.

But that also happens on the main branch on AppVeyor and probably also Travis CI.

minggangw commented 3 years ago

I've re-triggered the appveyor, my experience is that the appveyor is not stable sometimes and you have to retry it. Hope it will pass this time and I will merge this PR once it's done, thanks!