Closed felixdivo closed 3 years ago
I don't get why AppVeyor is failing though. But maybe it will go away now. Let's see.
I don't get why AppVeyor is failing though. But maybe it will go away now. Let's see.
It didn't. This war the failing test I meant (@minggangw ;)). Seems like node ./scripts/compile_tests.js
fails. I can't see why this would be cause by my changes. It appears that a few lines above, this shows up:
> node scripts/generate_messages.js
Start JavaScript message generation...
Incomplete service: test_interface_files.srv.Arrays.
Incomplete service: test_interface_files.srv.BasicTypes.
Incomplete service: test_interface_files.srv.Empty.
Generation complete.
But that also happens on the main branch on AppVeyor and probably also Travis CI.
I've re-triggered the appveyor, my experience is that the appveyor is not stable sometimes and you have to retry it. Hope it will pass this time and I will merge this PR once it's done, thanks!
Fixes #736.