RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
316 stars 70 forks source link

benchmark code does not build on foxy #739

Closed wayneparrott closed 3 years ago

wayneparrott commented 3 years ago

There are issues building and running the rclcpp and rclpy benchmark code on foxy. One issue is the Node#create_publisher() now requires a qos argument.

minggangw commented 3 years ago

Yes, the examples haven't been updated for a long time and the interfaces of rclpy/rclcpp have changed.

wayneparrott commented 3 years ago

@minggangw I can give this a look next week if you want to assign it to me?

I'm personally interested in seeing the comparative benchmarks between js, c++ and python. Also we might be able to also see how the different DDS middleware performance compares.

minggangw commented 3 years ago

Please take this issue, thanks!