Use specified deleter for RclHandle

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client

https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained

Apache License 2.0

316 stars 70 forks source link

Use specified deleter for RclHandle #743

Closed minggangw closed 3 years ago

minggangw commented 3 years ago

This patch will enable RclHandle to use a specified deleter to free the resources, which means the pointer passed when contructing the RclHandle object will not be freed by default.

After this patch, caller should be responsible to manage the memory.

Fix #728

coveralls commented 3 years ago

Coverage remained the same at 91.289% when pulling cd22efebf7b577aca41f2b3c0b0a94e1a8b33b3b on minggangw:fix-issue-728 into d4b9cb701d0c6c0fbe35727b3cd2693bf0cf1d13 on RobotWebTools:develop.

minggangw commented 3 years ago

@wayneparrott @koonpeng PTAL, thanks!