search

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
316 stars 70 forks source link

Don't login docker hub anonymous #767

Closed minggangw closed 3 years ago

minggangw commented 3 years ago

Becasue rate limits anonymous and free authenticated use of Docker Hub went into effect (https://www.docker.com/increase-rate-limits), we need to login docker with an account.

This patch sets two environment variables (DOCKER_PASSWORD & DOCKER_USERNAME) for the travis-ci that will be used to login to the docker hub, thus, we could break the limiting. Please be aware, the PR submitted from a fork repo will not use this account due to https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

Fix #766

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 91.787% when pulling 46b5705b89c2c2e0b752fe322b53ed2b8cf9e65f on minggangw:fix-issue-766 into 6cf3db02a3760e96274f00a1aa47155ae79af74b on RobotWebTools:develop.