RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
316 stars 70 forks source link

Run rclnodejs with Node.js (>= 10 and <=12) on appveyor #773

Closed minggangw closed 3 years ago

minggangw commented 3 years ago

Recently, we observerd that rcnodejs is not supported by some version of Node.js, because some new features the current JS code used are not supported by these versions yet.

This patch replaces these cases with compatible patterns. As the nodejs v8.x has been EOF already (https://nodejs.org/en/about/releases/), we decided to drop it. (Another reason is that some depenency of rclnodejs requires nodejs >= 10.x)

Meanwhile, we are going to use a matrix to run Node.js (LTS) version for both 10 and 12.

Fix #768

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-0.3%) to 91.442% when pulling d1a762d88d94b6b7840a24890aa9e107500f036c on minggangw:fix-issue-768 into 2603d22570e547d9c7b01782b80004a7e0d70a12 on RobotWebTools:develop.