RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
320 stars 70 forks source link

LifecycleNode constructor missing enableCommunicationInterface parameter added in ROS2 Galactic #799

Closed wayneparrott closed 3 years ago

wayneparrott commented 3 years ago

This issue is a reminder that LifecycleNode constructor needs to be updated to reflect the additional constructor parameter enableCommunicationInterface. This parameter was added in the Galactic rcl release and has a default = true for backwards compatibility. We committed a quick partial implementation of the default behavior for the 0.19 release. Now we need to enable the ability to disable lifecycle service interfaces.

https://docs.ros.org/en/foxy/Releases/Release-Galactic-Geochelone.html#rcl-lifecycle-and-rclcpp-lifecycle