Implements LifecycleNode constructor enableCommunicationInterface

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client

https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained

Apache License 2.0

312 stars 70 forks source link

Implements LifecycleNode constructor enableCommunicationInterface #800

Closed wayneparrott closed 3 years ago

wayneparrott commented 3 years ago

lifecycle-node.js lifecycle-node.d.ts rcl_lifecycle_binding.cpp main.ts

added support for enableCommunicationInterface param

index.js

added support for enableCommunicationInterface param

index.d.ts

added support for enableCommunicationInterface param
added @deprecated tag to createNode() & createLifecycleNode()

test-lifecycle.js

added 2 test to cover pos and neg versions of enableCommunicationInterface parameter

Fix #799

wayneparrott commented 3 years ago

will fix the silly EOL prettier issues asap and update.

minggangw commented 3 years ago

Thanks for making this progress!

coveralls commented 3 years ago

Coverage decreased (-0.4%) to 90.62% when pulling 73c8ff1c716123b606aed31a505a1ecea5dae3d3 on wayneparrott:optional-lifecycle-service into 9a9e53f691488542a94ce93e459a293342f221b0 on RobotWebTools:develop.