RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
311 stars 70 forks source link

appveyor builds occasionally fail for node 16 & 17 specifically on galactic branch #829

Closed wayneparrott closed 2 years ago

wayneparrott commented 2 years ago

appveyor builds occasionally fail for node 16 & 17 I've been successfully running the appveyor build matrix over the past 36 hrs and now after merging a key PR appveyor builds are failing for node 16 & 17 on the galactic branch. I do not observe the error below on the develop branch. A common error follows:

SET PATH=%PYTHON2%;%PYTHON2%\bin;%PYTHON2%\Scripts;%PATH%
node --version
v16.13.0
npm --version
8.1.0
python --version
Python 2.7.18
npm install
npm ERR! code 1
npm ERR! path C:\proj\rclnodejs\node_modules\@rclnodejs\ref-napi
npm ERR! command failed
npm ERR! command C:\Windows\system32\cmd.exe /d /s /c node-gyp rebuild
npm ERR! gyp:
C:\Users\appveyor\AppData\Local\node-gyp\Cache\16.13.0\common.gypi not
found (cwd: C:\proj\rclnodejs\node_modules\@rclnodejs\ref-napi) while
reading includes of binding.gyp while trying to load binding.gyp
npm ERR! gyp ERR! configure error
npm ERR! gyp ERR! stack Error: `gyp` failed with exit code: 1
npm ERR! gyp ERR! stack     at ChildProcess.onCpExit (C:\Program
Files\nodejs\node_modules\npm\node_modules\node-gyp\lib\configure.js:353:16)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:390:28)
npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit
(node:internal/child_process:290:12)
npm ERR! gyp ERR! System Windows_NT 10.0.17763
npm ERR! gyp ERR! command "C:\\Program Files\\nodejs\\node.exe"
"C:\\Program Files\\nodejs\\node_modules\\npm\\node_modules\\node-gyp\\bin\\node-gyp.js"
"rebuild"
npm ERR! gyp ERR! cwd C:\proj\rclnodejs\node_modules\@rclnodejs\ref-napi
npm ERR! gyp ERR! node -v v16.13.0
npm ERR! gyp ERR! node-gyp -v v8.2.0
npm ERR! gyp ERR! not ok
npm ERR! A complete log of this run can be found in:
...

appveyor.yml - reversed the order of node versions to be in decending order, e.g., 17, 16, ... Doing this will speed up identifying build failures and debug-fix iterations.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 90.471% when pulling 651ed2061783ec78d3c174151a92f4862c45a622 on wayneparrott:galactic-geochelone into 13e5d314e98a4f54cd089f9ad998cd13b47a01d1 on RobotWebTools:galactic-geochelone.