search

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/jazzy/Concepts/Basic/About-Client-Libraries.html#community-maintained
Apache License 2.0
335 stars 72 forks source link

Free memory allocated for typed arrays #843

Closed minggangw closed 2 years ago

minggangw commented 2 years ago

This patch fixed the memory leak when using typed arrays on nodejs > 10

Fix: #842

wayneparrott commented 2 years ago

@minggangw bummer that dtslint is failing the test suite because of transposed union types, e.g.,

Error: /home/runner/work/rclnodejs/rclnodejs/test/types/main.ts:319:1
ERROR: 319:1  expect  TypeScript@4.7 expected type to be:
  Duration | Time
got:
  Time | Duration
ERROR: 322:1  expect  TypeScript@4.7 expected type to be:
  Duration | Time
got:
  Time | Duration

We saw this a while back. I'll give it a look asap.

wayneparrott commented 2 years ago

See PRs #847 and #848 which combined should fix the linux workflow failures.