do not convert bool to string for parameter msg

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client

https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained

Apache License 2.0

311 stars 70 forks source link

do not convert bool to string for parameter msg #851

Closed imcelroy closed 2 years ago

imcelroy commented 2 years ago

Public API Changes

None

Description

Remove conversion of bool values to strings for ParameterType.PARAMETER_BOOL and ParameterType.PARAMETER_BOOL_ARRAY in Parameter.toParameterMessage(). The rclcpp methods Parameter::as_bool() and Parameter::as_bool_array() do not convert these messages correctly if they contain bools as strings.

fixes: 850

wayneparrott commented 2 years ago

Thx for the PR. Will review later today.