RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
311 stars 70 forks source link

Fix issues when using parameters of type array #855

Closed ejalaa12 closed 2 years ago

ejalaa12 commented 2 years ago

Public API Changes None

Description

This PR fixes the following issues with parameters when the parameter type is an array. (in order of commits)

Unit tests were added to reproduce the bugs, then the next commits fix those bugs.

wayneparrott commented 2 years ago

@ejalaa12 thx for helping improve parameter support. Your efforts have been most appreciated.

OT - may I ask how you are using rclnodejs? Also please open an issue if you have suggestions for improving the use of rclnodejs including the onboarding experience.

ejalaa12 commented 2 years ago

@wayneparrott you're welcome. It's a great job you guys are doing already.

We're using rclnodejs as a backend to the HMI that controls our ros2 robot and some other products.

We'll be sure to drop new PR/Issue when needed :)

Thanks for the merge !