RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
311 stars 70 forks source link

Verify rclnodejs for the usage of ArrayBuffers on Electron > 20 #875

Closed minggangw closed 1 year ago

minggangw commented 1 year ago

@wayneparrott noticed that Electron will enable sandboxed pointers of v8 on version > 20, which may break our tests potentially, see the below details:

The main downside of enabling sandboxed pointers is that ArrayBuffers which point to external ("off-heap") memory are no longer allowed. This means that native modules which rely on this functionality in V8 will need to be refactored to continue working in Electron 20 and later.

We need to take action to verify our module on Electron > 20

minggangw commented 1 year ago

921 fixed the sandboxed pointers issue after electron 21