RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
311 stars 70 forks source link

Bug in windows workflow #877

Closed wayneparrott closed 1 year ago

wayneparrott commented 1 year ago

The following line is goofed and causes all windows builds to fail as ${{ needs.identify-ros-distro.outputs.distro }} is undefined on windows: https://github.com/RobotWebTools/rclnodejs/blob/4ebb442e1f5785942415ce0ffcca63e769da375a/.github/workflows/windows-build-and-test-compatibility.yml#L51

The corrected line should read:

call "c:\dev\${{ matrix.ros_distribution }}\ros2-windows\setup.bat"