Support Node 18 - Githubissues

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client

Apache License 2.0

311 stars 70 forks source link

Closed wayneparrott closed 1 year ago

wayneparrott commented 1 year ago

package.json includes this node version constraint:

  "engines": {
    "node": ">= 10.23.1 <18.0.0"
  }

I ran a quick test with node 18. The rclnodejs test suite passes with node v18.12.1 (LTS) on ROS humble and galactic distros.

@minggangw Thoughts on expanding support to Node 18?

minggangw commented 1 year ago

Agree, we can include the nodejs 18 now, please go ahead to change it, thanks!

minggangw commented 1 year ago

Close it due to #884