search

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
311 stars 70 forks source link

Fixes recent break with ros-tooling/setup-ros@v0.4 #899

Closed wayneparrott closed 1 year ago

wayneparrott commented 1 year ago

Update to ros-tooling/setup-ros@v0.6

wayneparrott commented 1 year ago

Windows builds are now breaking with the latest rolling build :( Will debug tomorrow (it's 1AM).

Building the projects in this solution one at a time. To enable parallel build, please add the "-m" switch.
  addon.cpp
  executor.cpp
  handle_manager.cpp
c:\dev\rolling\ros2-windows\include\action_msgs\action_msgs\srv\detail\cancel_goal__struct.h(121,10): fatal error C1083: Cannot open include file: 'service_msgs/msg/detail/service_event_info__struct.h': No such file or directory [D:\a\rclnodejs\rclnodejs\build\rclnodejs.vcxproj]
gyp ERR! build error 
gyp ERR! stack Error: `C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Current\Bin\MSBuild.exe` failed with exit code: 1
...
wayneparrott commented 1 year ago

bindings.gyp requires more tuning to handle the new service_msgs properly across the different ROS versions.

wayneparrott commented 1 year ago

This PR is premature and doesn't address the CI issues adequately. Deleting this PR to revisit several issues and how best to resolve them. Will resubmit multiple fixes after more testing.