search

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
311 stars 70 forks source link

Fix typos in documentation #910

Closed IsabelParedes closed 1 year ago

IsabelParedes commented 1 year ago

Public API Changes

None

Description

This PR simply fixes a few typos in the documentation.

wayneparrott commented 1 year ago

@ihuicatl thx for the type fixes. much appreciated. OT - ros2wasm looks interesting. I've wondered about use of wasm in ros for awhile.

IsabelParedes commented 1 year ago

Hi @wayneparrott, thanks for the review! I was actually looking into possibly integrating rclnodejs into the ros2wasm project. So if you have any tips I'd be pretty interested :)

minggangw commented 1 year ago

@ihuicatl thanks for fixing the typos!

minggangw commented 1 year ago

Hi @wayneparrott, thanks for the review! I was actually looking into possibly integrating rclnodejs into the ros2wasm project. So if you have any tips I'd be pretty interested :)

Never think about compiling rclnodejs to wasm, interesting! I'm not clear how you can deal with the addon written in C++, please update us if you have progress :) By the way, is there any motivation for you to leverage wasm?

IsabelParedes commented 1 year ago

Hi @minggangw! Currently the motivation is from an educational perspective. I worked on setting up a ROS environment with JupyterHub for a university course before, and having a ROS environment run entirely on the browser would be a step up from that. Right now I have some publisher and subscriber nodes running on the browser but I'm looking to add more interaction which is where integrating rclnodejs would be really nice to have. For the addon in C++, that should be compile-able with Emscripten which is how I've been compiling the rest of the ROS packages. I think I'll have to figure out how to detect my wasm modules as a valid ROS installation though.

minggangw commented 1 year ago

@ihuicatl I see, that makes sense. Have you tried with roslibjs, which can support ROS2 on the browser, or Electron? Because both can save a lot of effort if you want to enable ROS2 on the browser.

IsabelParedes commented 1 year ago

Hi @minggangw, I took a look at roslibjs before but wasn't sure if it supported ROS2 since I only saw one ros2 branch. But roslibjs seems to rely on a rosbridge connection to a native ROS installation, which I feel like I would run into the same problem that I'd have to figure out how to connect roslibjs to wasm modules without relying on a native ROS installation nor rosbridge. I haven't used Electron before but that seems more for creating desktop applications which is not exactly what I'm trying to do. I'm simply trying to have ROS2 run on a website without requiring any installations by the user.