RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
311 stars 70 forks source link

possible bug when processing raw subscription message? #911

Closed wayneparrott closed 1 year ago

wayneparrott commented 1 year ago

@minggangw In node.js#execute() should the following highlighted line be continue rather than return?

image

https://github.com/RobotWebTools/rclnodejs/blame/369e765f38fd0560876bc36e5dc5d85a2ac16171/lib/node.js#L188

minggangw commented 1 year ago

@wayneparrott good catching! it should use continue, otherwise, other subscriptions will not receive any response which is not raw messge.