RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
311 stars 70 forks source link

Fix wrong clock message type #928

Closed AntoninRousset closed 10 months ago

AntoninRousset commented 10 months ago

Public API Changes None

Description Changes the subscription type on /clock from builtin_interfaces/msg/Time to rosgraph_msgs/msg/Clock.

https://github.com/RobotWebTools/rclnodejs/issues/927

minggangw commented 10 months ago

@AntoninRousset thanks for submitting the patch, I will take a look.

minggangw commented 10 months ago

@AntoninRousset The tests running on the rolling build failed due to a build break, I guess it was caused by some recent changes on rolling. I have look the PR, it looks good to me, so I would merge it first and solve the build break later, thanks!