search

RobotWebTools / rclnodejs

Node.js version of ROS 2.0 client
https://docs.ros.org/en/humble/Concepts/Basic/About-Client-Libraries.html?highlight=rclnodejs#community-maintained
Apache License 2.0
311 stars 70 forks source link

Move rimraf to dependencies #954

Closed chfritz closed 5 months ago

chfritz commented 5 months ago

Public API Changes None

Description rimraf is used in the install script (via rebuild -> clean) and as such is always required, not just in dev. devDependencies are not installed transitively, so when using rclnodejs in a package that is used in another project, rimraf is not installed, leading to an error during installation.

minggangw commented 5 months ago

@chfritz Thanks for submitting the fix, approved!