RobotWebTools / ros2-web-bridge

Bridging your browser to the ROS 2.0
Apache License 2.0
203 stars 68 forks source link

Latest rclnodejs version 0.19.0 doesn't work on Foxy #187

Open ManuelZ opened 3 years ago

ManuelZ commented 3 years ago

I'm using Foxy and installing ros2-web-bridge through npn, which depends on rclnodejs version 0.x.1, which lately means installing 0.19.0, which doesn't work on Foxy. It brings up an error as stated here: https://github.com/RobotWebTools/rclnodejs/issues/792

What could be done to allow a Foxy user to install ros2-web-bridge without trouble?

Aposhian commented 3 years ago

I think that ros2-web-bridge 0.3 should lock down the rclnodejs dependency to ^0.18.x and bump the version for galactic to 0.4. I can make a PR for that if that is in line with how this project is going to manage versions for different ROS2 releases.

emersonknapp commented 3 years ago

That seems like a good strategy to me - perhaps we should note the version-mappingin the README as well - a simple table like:

minggangw commented 3 years ago

This issue has been fixed by https://github.com/RobotWebTools/rclnodejs/commit/ab69738d8978f37549bec36ba5c6fd8838b5b243, and you can find which version matches a specific ROS release at https://github.com/RobotWebTools/rclnodejs#installing-rclnodejs

minggangw commented 3 years ago

Please upgrade the rclnodejs to 0.19.1 that has resolved the incompatibility problem on Galactic.