search

RobotWebTools / rosbridge_suite

Server Implementations of the rosbridge v2 Protocol
https://robotwebtools.github.io
BSD 3-Clause "New" or "Revised" License
924 stars 519 forks source link

Foxy Release? #536

Closed JWhitleyWork closed 3 years ago

JWhitleyWork commented 4 years ago

Expected Behavior

This stack is availaable on the ROS Build Farm for supported versions of ROS2.

Actual Behavior

A dashing release exists but not a foxy one.

Dependencies that Need Releasing

JWhitleyWork commented 4 years ago

I have verified that the stack builds with the source version of rosauth on the ros2 branch.

JWhitleyWork commented 3 years ago

rosauth now has a release pending sync. Can the maintainer of this repo (@mvollrath ?) please consider a ROS Foxy release from the ros2 branch?

JWhitleyWork commented 3 years ago

Ping to @mvollrath for Foxy release. rosauth is now available in the repositories.

mvollrath commented 3 years ago

Would like to see a new distro appear in CI tests before releasing the package.

JWhitleyWork commented 3 years ago

@mvollrath The ros2 branch already has Foxy jobs, but only on PRs. See https://github.com/RobotWebTools/rosbridge_suite/blob/ros2/.github/workflows/ros_ci.yml.

sageig commented 3 years ago

Just wanted to note that the Foxy job will build successfully if the setup-ros and action-ros-ci versions are updated from 0.0.25 and 0.0.19, respectively, to 0.1.0. I tested it in this PR. However, the dashing and eloquent jobs are failing in the same manner as the kinetic and melodic jobs.

sageig commented 3 years ago

@mvollrath Does the above suffice, or are there other things you're looking for that could help us move this forward?

jtbandes commented 3 years ago

Hi folks, what was the status of this? What will it take in order to get rosbridge-suite released for Galactic/Humble?

amacneil commented 3 years ago

This was discussed in the ros web tools working group today, and will happen soon.

jtbandes commented 3 years ago
JWhitleyWork commented 3 years ago

Thank you!

amacneil commented 3 years ago

FYI these packages will probably take 1-2 weeks before they are published to apt repos (when the next sync happens). We will also publish a new version of Foxglove Studio next week with support for ROS 2 rosbridge connections.

JWhitleyWork commented 3 years ago

Yup, totally fine.