RobotWebTools / rosbridge_suite

Server Implementations of the rosbridge v2 Protocol

https://robotwebtools.github.io

BSD 3-Clause "New" or "Revised" License

897 stars 514 forks source link

Handle ROS 2 types properly #883

Closed scottbell closed 11 months ago

scottbell commented 11 months ago

Public API Changes

None

Description

Handle ROS2 types properly when building type definitions. Don't crash when handling unknown types. Added test coverage for objectutils.

Fixes #834 #822 #821

EzraBrooks commented 11 months ago

Hey @scottbell, thanks for the PR! This looks more complete than my previous implementation in #840. I'll give this a shot today in my workspace which has experienced some of these issues.

scottbell commented 11 months ago

This change worked in my workspace that previously was running PR #840, so this LGTM. Code looks reasonable to me - thanks!

Thank you for testing!

Hytac commented 10 months ago

Hi, I'm still using #840.

883 still giving the error to me

all_service AttributeError: 'float' object has no attribute 'get_fields_and_field_types' My msg is moveit_msgs/msg/PlanningScene

sea-bass commented 10 months ago

I think ROS 2 needs float32 or float64 if I recall correctly?