search

RobotWebTools / rosbridge_suite

Server Implementations of the rosbridge v2 Protocol
https://robotwebtools.github.io
BSD 3-Clause "New" or "Revised" License
866 stars 506 forks source link

fix type object is not iterable error #894

Closed gulerburak closed 14 hours ago

gulerburak commented 7 months ago

Public API Changes

Description

To fix runtime error on isaac ros mqtt ros2 bridge, added this line to the affected files. from __future__ import annotations

sea-bass commented 7 months ago

What Python version are you on that doesn't support type annotations? I think if it's below Python 3.8, I'd say we shouldn't support this on the main branch.

Otherwise, we can at least put this import under a version checking guard, like:

https://stackoverflow.com/a/11887885

In other words, if the version is less than X, only then import annotations from __future__.

And also, seems like lint is failing. You can do pre-commit run -a to resolve these issues.

github-actions[bot] commented 1 month ago

This PR has been marked as stale because there has been no activity in the past 6 months. Please add a comment to keep it open.