search

RobotWebTools / roslibjs

The Standard ROS JavaScript Library
https://robotwebtools.github.io/roslibjs
Other
691 stars 382 forks source link

Remove sudo from npm install #177

Closed rctoris closed 9 years ago

rctoris commented 9 years ago

Currently npm install will run misc/install.sh which runs some sudo commands. This is unexpected behavior to many and breaks many automated scripts. I propose removing this from the npm install script and placing the instruction to run the script in the README instead.

megawac commented 9 years ago

Related #133. Ideally we could detect if libcario is installed. If it isn't

a) install it (requiring sudo) b) Error the build and give users instruction on how to install it

Also I'm not even sure if we need libcario for what we use canvas for (if someone adds some unit tests related to png decompressing we can verify)

jihoonl commented 9 years ago

I would suggest b) to resolve the issue. This is issue of node-canvas not internal problem of roslibjs.

rctoris commented 9 years ago

+1 to b

rctoris commented 9 years ago

@jihoonl can you run a npm release to propagate this please?

jihoonl commented 9 years ago

Done.

https://www.npmjs.com/package/roslib