search

RobotWebTools / roslibjs

The Standard ROS JavaScript Library
https://robotwebtools.github.io/roslibjs
Other
691 stars 382 forks source link

wrong name in bower.json? #269

Closed ensonic closed 7 years ago

ensonic commented 7 years ago

See https://github.com/RobotWebTools/roslibjs/blob/develop/bower.json#L2

should this be roslibjs instead of roslib? I can send a PR.

jihoonl commented 7 years ago

No, it should be roslib to match with the module name. And, it has been serving the module as roslib quite a while already. So, it would make sense to stay with the current naming.

jihoonl commented 7 years ago

It is also roslib in package.json

ensonic commented 7 years ago

Ok, but then packages like https://github.com/RobotWebTools/ros3djs/blob/develop/bower.json#L26 should probably reference it as "roslib", right?