RobotWebTools / roslibjs

The Standard ROS JavaScript Library
https://robotwebtools.github.io/roslibjs
Other
660 stars 372 forks source link

Correct CDN to use #614

Closed torydebra closed 1 year ago

torydebra commented 1 year ago

Description

Steps To Reproduce The CDN indicated in the ROS tutorials seems to not work anymore :

<script src="http://static.robotwebtools.org/EventEmitter2/current/eventemitter2.js"></script>
<script src="http://static.robotwebtools.org/roslibjs/current/roslib.js"></script>

Is the new correct CDN to be used the one indicated in the readme? What about the eventemitter2.js file?

https://cdn.jsdelivr.net/npm/roslib@1/build/roslib.min.js

Thanks!

MatthijsBurgh commented 1 year ago

Forget about the ROS wiki, that one is really out-of-date.

The README is correct.

For eventemitter2 use https://cdn.jsdelivr.net/npm/eventemitter2@6/lib/eventemitter2.min.js I will add this to the README.

MatthijsBurgh commented 1 year ago

I think EventEmitter2 is included in the build and therefore no EventEmitter CDN is needed.

I will run the examples later to confirm this.

MatthijsBurgh commented 1 year ago

Yes, I have tested the examples without EventEmitter CDN and these work.