search

RobotWebTools / roslibjs

The Standard ROS JavaScript Library
https://robotwebtools.github.io/roslibjs
Other
660 stars 372 forks source link

Don't check in built content #643

Closed EzraBrooks closed 6 months ago

EzraBrooks commented 8 months ago

Public API Changes

None

Description

Removes the built content from the repository to avoid accidental creation of giant, hard-to-resolve diffs in PRs.

WIP/TODO: how to handle examples? should these require building? can we inject a browser require polyfill (if we're not already) to make the raw src work fine?

MatthijsBurgh commented 8 months ago

The only wat I accept such a change is, when we attach builds to the releases and/or release branches.

EzraBrooks commented 8 months ago

The only wat I accept such a change is, when we attach builds to the releases and/or release branches.

Can you explain to me why the built content is checked into the repo? This is extremely atypical in my experience. The JavaScript ecosystem has package managers that work, we don't need to ship tarballs.

EzraBrooks commented 6 months ago

Superseded by #655